Add Ability to customize favourites/inputs list #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed max-favorites value accessibility in config-schema - Added option to hide airplay, Line-in, and TV sources from the TV inputs in HomeKit upon startup, subsequently taking them out of the favorites list when cycling through inputs. Eventually I want to separate the TV audio out of this, and make dynamic checkboxes (maybe under advanced) for zones which actually have connected TVs, so that only those zones will have TV audio enabled. But for now this is just a catch all, when I tried to implement the dynamic TV stuff things kept breaking ;) I'll keep playing with it but wanted to start incrementally. - fixed MaxFavourites to be a text field that is visible to the VoiceOver screenreader on Mac OS. It was previously a slider that the screenreader saw as being set to 56 and if you changed the value, nothing actually changed in the config. - made force S2 a checkbox instead of an edit field. - added note about excluding airplay (as I discovered the hard way, luckily in a test environment) - Please feel free to test with different variables etc, but everything works normally for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is attempting to start preliminary work on fixing issue #206 and does the following:
Eventually I want to separate the TV audio out of this, and make dynamic checkboxes (maybe under advanced) for zones which actually have connected TVs, so that only those zones will have TV audio enabled. But for now this is just a catch all, when I tried to implement the dynamic TV stuff things kept breaking ;) I'll keep playing with it but wanted to start incrementally.
fixed MaxFavourites to be a text field that is visible to the VoiceOver screenreader on Mac OS. It was previously a slider that the screenreader saw as being set to 56 and if you changed the value, nothing actually changed in the config.
made force S2 a checkbox instead of an edit field.
added note about excluding airplay (as I discovered the hard way, luckily in a test environment)
Please feel free to test with different variables/configs etc, but everything works normally for me.